[PATCH] i386: Correct adcx suffix in disassembler

Jan Beulich jbeulich@suse.com
Mon Jan 8 07:32:32 GMT 2024


On 07.01.2024 21:07, H.J. Lu wrote:
> Since 0x66 is the opcode prefix for adcx, it is wrong to use the 'S'
> prefix:
> 
>   'S' => print 'w', 'l' or 'q' if suffix_always is true
> 
> on adcx.  Add
> 
>   'L' => print 'l' or 'q' if suffix_always is true
> 
> replace S with L on adcx and adox.

Instead of consuming a precious single-character macro with just two
uses, did you consider re-using / adjusting an existing one? I'd
rather use a few of the single-character ones (several of which I
managed to free up) to replace frequently used multi-character ones.

Jan


More information about the Binutils mailing list