[PATCH 2/2] x86: Append "#pass" to APX tests

Jan Beulich jbeulich@suse.com
Thu Jan 4 09:35:35 GMT 2024


On 30.12.2023 00:50, H.J. Lu wrote:
> Append "#pass" to APX tests for targets which pad text sections with NOPs.
> 
> 	* testsuite/gas/i386/x86-64-apx-evex-promoted-bad.d: Append
> 	"#pass".
> 	* testsuite/gas/i386/x86-64-apx-ndd-optimize.d: Likewise.
> 	* testsuite/gas/i386/x86-64-apx-ndd.d: Likewise.
> 	* testsuite/gas/i386/x86-64-apx-pushp-popp-intel.d: Likewise.
> 	* testsuite/gas/i386/x86-64-apx-pushp-popp.d: Likewise.

It's interesting that you found a need for this, when I'm sure I made a
comment to this effect during review (somewhere in the series, but
obviously applicable throughout). When approving, you didn't check that
all review comments were addressed, did you?

Jan


More information about the Binutils mailing list