[PATCH v1 0/4][Binutils] aarch64: testsuite: refactoring of some tests to share test macros

Matthieu Longo matthieu.longo@arm.com
Tue Feb 27 10:59:13 GMT 2024


Hi,

[patch 0/4] aarch64: testsuite: refactoring of some sysreg tests to share test macros
  [patch v1 1/4] aarch64: testsuite: replace instruction addresses by regex
  [patch v1 2/4] aarch64: testsuite: use same regs for read and write tests
  [patch v1 3/4] aarch64: testsuite: reorder write and read to match macro order
  [patch v1 4/4] aarch64: testsuite: share test utils macros and use them

This patch series proposes a refactoring of sysreg tests focusing on:
- replacing hard-coded instruction addresses by regexes in the objdump test output files (.d)
- simplifying the usage of macro by using the same register for reading and writing
- providing 2 macros to read/write from/to sysregs
- adapting the tests to use those 2 macros
More details are available in the individual commit messages.

Regression tested on the aarch64-none-elf, and no regression was found.

Ok for binutils-master? I don't have commit access so I need someone to commit on my behalf.

Regards,
Matthieu.

 .../aarch64/sysreg/armv8_9-a-sysregs-bad.d    |   2 +-
 .../aarch64/sysreg/armv8_9-a-sysregs-bad.l    | 142 ++++-
 .../gas/aarch64/sysreg/armv8_9-a-sysregs.d    |  91 +--
 .../gas/aarch64/sysreg/armv8_9-a-sysregs.s    | 143 ++---
 .../gas/aarch64/sysreg/illegal-sysreg-3.d     |   2 +-
 .../gas/aarch64/sysreg/illegal-sysreg-4.d     |   2 +-
 gas/testsuite/gas/aarch64/sysreg/sysreg-1.d   |   2 +
 gas/testsuite/gas/aarch64/sysreg/sysreg-1.s   | 223 ++++----
 gas/testsuite/gas/aarch64/sysreg/sysreg-2.d   | 105 ++--
 gas/testsuite/gas/aarch64/sysreg/sysreg-2.s   |  47 +-
 gas/testsuite/gas/aarch64/sysreg/sysreg-3.d   |  43 +-
 gas/testsuite/gas/aarch64/sysreg/sysreg-3.s   |  25 +-
 gas/testsuite/gas/aarch64/sysreg/sysreg-6.d   |   2 +
 gas/testsuite/gas/aarch64/sysreg/sysreg-6.s   |   7 +-
 gas/testsuite/gas/aarch64/sysreg/sysreg-7.d   |  18 +-
 gas/testsuite/gas/aarch64/sysreg/sysreg-7.s   |  34 +-
 gas/testsuite/gas/aarch64/sysreg/sysreg-8.d   | 530 +++++++++---------
 gas/testsuite/gas/aarch64/sysreg/sysreg-8.s   | 339 ++++++-----
 .../gas/aarch64/sysreg/sysreg-test-utils.inc  |  32 ++
 gas/testsuite/gas/aarch64/sysreg/sysreg.d     |  58 +-
 gas/testsuite/gas/aarch64/sysreg/sysreg.s     |  63 +--
 gas/testsuite/gas/aarch64/sysreg/sysreg128.d  |  42 +-
 gas/testsuite/gas/aarch64/sysreg/sysreg128.s  |  27 +-
 23 files changed, 1015 insertions(+), 964 deletions(-)
 create mode 100644 gas/testsuite/gas/aarch64/sysreg/sysreg-test-utils.inc

-- 
2.34.1



More information about the Binutils mailing list