[PATCH v2 1/9] x86: Remove unused SFrame CFI RA register variable

Indu Bhagat indu.bhagat@oracle.com
Sat Feb 24 07:38:01 GMT 2024


On 2/23/24 09:07, Jens Remus wrote:
> gas/
> 	* config/tc-i386.c: Remove unused SFrame CFI RA register
> 	  variable.
> 

The ChangeLog formatting is a bit off here and in the rest of the 
patches in this series.

The indentation of each line should be such that all content lines up 
below the *, like so:

<TAB>* xyz.c: first line content
<TAB>next line content

Other than that, LGTM.

Thanks
Indu

> Reviewed-by: Andreas Krebbel <krebbel@linux.ibm.com>
> Signed-off-by: Jens Remus <jremus@linux.ibm.com>
> ---
>   gas/config/tc-i386.c | 1 -
>   1 file changed, 1 deletion(-)
> 
> diff --git a/gas/config/tc-i386.c b/gas/config/tc-i386.c
> index c56ca4a2b4b8..1a6fd52f229a 100644
> --- a/gas/config/tc-i386.c
> +++ b/gas/config/tc-i386.c
> @@ -627,7 +627,6 @@ static int shared = 0;
>   unsigned int x86_sframe_cfa_sp_reg;
>   /* The other CFA base register for SFrame stack trace info.  */
>   unsigned int x86_sframe_cfa_fp_reg;
> -unsigned int x86_sframe_cfa_ra_reg;
>   
>   #endif
>   



More information about the Binutils mailing list