[PATCH 0/1] objdump: Add callx support for BPF CPU v1

[Nick Clifton]

Hi Will,

> First time patch submitter but long time GNU enthusiast. Thank you for
> all the work that you all do to maintain these vital pieces of software
> for the community.

Welcome on board and thank you contributing.


> I tried very hard to follow best practices for creating this patch
> submission but I am sure that I did something wrong. Please let me know
> what I can do differently or better.

No, no, what you did was excellent.  My only suggestions is that
with your v2 patch you consider adding a new assembler test (or
extending an already existing one) that checks that the instruction
can be assembled and then disassembled.  For example you might
like to add it to gas/testsuite/gas/bpf/call.s (and the associated
call.d file for the disassembly).

Cheers
   Nick