[PATCH] MIPS/Gas: Support .L/$ as the mark of local symbol

YunQiang Su syq@gcc.gnu.org
Mon Feb 5 10:14:27 GMT 2024


In as.texi, there are lines:
  A local symbol is any symbol beginning with certain local
  label prefixes. By default, the local label prefix is
  @samp{.L} for ELF systems or @samp{L} for traditional a.out
  systems, but each target may have its own set of local
  label prefixes.

Let's support it for MIPS:
1) For OldABI, GCC uses "$" to mark local symbols, and
   for NewABI, ".L" is used. So let's support both for
   OldABI, and ".L" only for NewABI.
2) Emit an fatal error, if a local symbol is used, while
   not defined, just like LLVM does.
---
 gas/config/tc-mips.c | 10 ++++++++++
 1 file changed, 10 insertions(+)

diff --git a/gas/config/tc-mips.c b/gas/config/tc-mips.c
index 43c12de2c8a..a84b13e1815 100644
--- a/gas/config/tc-mips.c
+++ b/gas/config/tc-mips.c
@@ -17725,6 +17725,16 @@ pic_need_relax (symbolS *sym)
   if (symbol_section_p (sym))
     return true;
 
+  if (strstr (S_GET_NAME (sym), ".L") == S_GET_NAME (sym)
+      || ((mips_abi == O64_ABI || mips_abi == O32_ABI)
+	   && strstr (S_GET_NAME (sym), "$") == S_GET_NAME (sym)))
+    {
+      if (!S_IS_DEFINED (sym))
+	as_fatal (_("undefined temporary symbol: %s"),
+		  S_GET_NAME (sym));
+      return true;
+    }
+
   symsec = S_GET_SEGMENT (sym);
 
   /* This must duplicate the test in adjust_reloc_syms.  */
-- 
2.39.2



More information about the Binutils mailing list