[PATCH v1] x86: Support ZHAOXIN padlock instructions

[Jan Beulich]

On 13.12.2024 04:25, Mayshao-oc wrote:
>       This patch adds support for Zhaoxin padlock instructions, and
> display all the padlock instructions using rep prefix instead of repz,
> because all padlock instructions don't effect zf flag.

Shouldn't the 2nd hunk changing gas/testsuite/gas/i386/padlock.s also
be part of the split out patch you sent out later (or yet another
separate one)?

For the xrng2 table entry in the disassembler, please make padding
adhere to what adjacent similar entries have.

And no, along the lines what Haochen indicated in his reply: You cannot
tie the new insns to the same old PadLock CPU feature. Iirc you had
that properly separate in the earlier form of the patch.

In those opcode table additions I'm also puzzled about where you insert
new entries: The table section looks to be at least partly sorted. I'd
expect you to respect that partial sorting.

Jan