[binutils-gdb] gas: partly restore how current_location() had worked

Sam James sam@gentoo.org
Thu Dec 5 07:08:10 GMT 2024


Jan Beulich <jbeulich@suse.com> writes:

> On 04.12.2024 03:35, Maciej W. Rozycki wrote:
>> On Tue, 3 Dec 2024, Jan Beulich via Binutils-cvs wrote:
>> 
>>> commit a3a47415b74d651dba205037cfc0fb600578c255
>>> Author: Jan Beulich <jbeulich@suse.com>
>>> Date:   Tue Dec 3 10:48:16 2024 +0100
>>>
>>>     gas: partly restore how current_location() had worked
>>>     
>>>     Commit 4a826962e760 changed its behavior without saying why, and without
>>>     putting in place any testcase demonstrating the required behavior.
>> 
>>  You could have used the references, including the testcase, I gave you in 
>> the discussion.  Putting blame in a commit message for what was the policy 
>> at the time is I think unjust and unfounded.
>
> Well, maybe. I'm sorry if you feel offended. I don't, however, think there
> ever was a policy to explicitly forbid describing changes beyond their
> mechanics.

I think, in that vein, it would have been worth including a link to the
elucidative ML discussion. No policy against that? ;)




More information about the Binutils mailing list