[PATCH 1/5] gas: streamline expr_build_dot()

[Maciej W. Rozycki]

On Wed, 4 Dec 2024, Maciej W. Rozycki wrote:

>  I'm not convinced by your simplification though, as the key here is to
> tie `expr_build_dot' to `dot_symbol', even if it adds extra layering and 
> effectively boils down to the same calculation your proposed replacement 
> does.  This layering is so that we have a single tracking symbol, as 
> proposed by Richard Sandiford to represent ".".  See the discussion in: 
> <https://inbox.sourceware.org/binutils/alpine.DEB.1.10.1010291442440.25860@tp.orcam.me.uk/> 
> for the rationale.

 I didn't notice you actually already committed the change.  Oh well.  It 
took me a couple of hours to refresh myself on this subject in the hectic 
time I've been through recently.  I guess I didn't make it, but then I did 
not consider this discussion closed yet just by the passing of time.

 As I say I'm not convinced it's an improvement even if the resulting code 
looks simpler, because it my view it breaks the structure around the dot 
symbol.  I think the change should be reverted unless you have really 
strong arguments in favour to keeping it.

  Maciej