binutils 2.14a i370 gas literal issue

[Paul Edwards]

> Binutils 2.14 built from the branch "binutils-2_14-branch" produces
> similar results as yours with regards to the C1s gone missing.

Thanks for that result Jens!

> As with 2.30 the offsets in the MVC instruction are not what
> I would expect coming from HLASM. This seems to be corrected
> in your customized build.

The only technical change I know of is this:

D:\devel\binutils\gas\config>cvs diff -c -r stage53 -r stage55
cvs diff: Diffing .
Index: tc-i370.c
===================================================================
RCS file: \cvsroot/binutils/gas/config/tc-i370.c,v
retrieving revision 1.4
retrieving revision 1.1.5.1
diff -c -r1.4 -r1.1.5.1
*** tc-i370.c   24 Oct 2022 09:59:13 -0000      1.4
--- tc-i370.c   20 Aug 2024 22:35:38 -0000      1.1.5.1
***************
*** 2366,2373 ****
        else
        {
          fix_new_exp (frag_now, f - frag_now->fr_literal, opcode->len,
!                      &fixups[i].exp,
!                      (operand->flags & I370_OPERAND_RELATIVE) != 0,
                       ((bfd_reloc_code_real_type)
                        (fixups[i].opindex + (int) BFD_RELOC_UNUSED)), 0);
        }
--- 2366,2372 ----
        else
        {
          fix_new_exp (frag_now, f - frag_now->fr_literal, opcode->len,
!                        &fixups[i].exp, 0,
                       ((bfd_reloc_code_real_type)
                        (fixups[i].opindex + (int) BFD_RELOC_UNUSED)), 0);
        }

D:\devel\binutils\gas\config>


(Linas Vepstas made it)

And looking at it closer, it does in fact apply to the MVC instruction,
so this is almost certainly what is making my build produce a better
result to yours.

> ~/temp/binutils-2.14-i370 $ bin/i370-linux-gnu-objdump -s paul.o
>
> paul.o:     file format elf32-i370
>
> Contents of section .text:
>   0000 d207d05c 7010d207 d0647012 00000000  ...\p....dp.....
>   0010 c2c2c2c2 c2c2c2c2 c2c2c2c2 c2c2c2c2  ................
> Contents of section .data:

Thanks for that result too - the c1 have disappeared - some
sort of random strike.

BFN. Paul.