[PATCH 0/7] gas: whitespace handling

[Jens Remus]

Hello Jan!

Am 09.08.2024 um 14:48 schrieb Jan Beulich:
> As per observations in target specific code (resulting in me stopping the
> effort there for the moment) there appears to be disagreement across the
> assembler whether to check for specific characters (blank and tab normally)
> or whether to use ISSPACE(). It clearly is an option is use ISSPACE()
> uniformly instead of the new is_whitespace(), just that ISSPACE() also
> yields "true" for characters we don't really consider whitespace; ISBLANK()
> would be closer to what the open-coded checks did so far. See also the
> CR_EOL uses in read.c and app.c.

s390 exclusively uses ISSPACE(). No open coded checks for specific 
whitespace characters (e.g. ' ' or '\t').

Are you suggesting that it would be safe to replace all occurrences of 
ISSPACE() with ISBLANK(), since that is probably the original intention 
of the code?

What would be the benefit of using is_whitespace() instead of ISBLANK()? 
Would that get the performance benefit from -f?

Thanks and regards,
Jens
-- 
Jens Remus
Linux on Z Development (D3303) and z/VSE Support
+49-7031-16-1128 Office
jremus@de.ibm.com

IBM

IBM Deutschland Research & Development GmbH; Vorsitzender des 
Aufsichtsrats: Wolfgang Wendt; Geschäftsführung: David Faller; Sitz der 
Gesellschaft: Böblingen; Registergericht: Amtsgericht Stuttgart, HRB 243294
IBM Data Privacy Statement: https://www.ibm.com/privacy/