[PATCH v3 3/3] gas: Add macro tests for PR gas/32073

H.J. Lu hjl.tools@gmail.com
Mon Aug 12 15:35:56 GMT 2024


On Mon, Aug 12, 2024 at 8:29 AM Jan Beulich <jbeulich@suse.com> wrote:
>
> On 12.08.2024 17:12, H.J. Lu wrote:
> > --- /dev/null
> > +++ b/gas/testsuite/gas/macros/arg1.d
> > @@ -0,0 +1,7 @@
> > +#objdump: -s -j .data
> > +
> > +.*: .*
> > +
> > +Contents of section .data:
> > + 0000 10111213 1415                        ......
> > +#pass
>
> Despite the #pass, isn't this going to fail for targets which pad sections
> to certain alignment? Or was that an issue only with text sections?

I don't think we pad data section.

> > --- /dev/null
> > +++ b/gas/testsuite/gas/macros/arg1.s
> > @@ -0,0 +1,12 @@
> > +# Test expression argument and a white space before argument added by
> > +# C preprocessor.
>
> Nit: It's not really "expression" that matters here, but expressions with
> inner whitespace.
>
> Jan

Will fix.

-- 
H.J.


More information about the Binutils mailing list