[PATCH v2 3/3] gas: Add macro tests for PR gas/32073

[H.J. Lu]

On Mon, Aug 12, 2024 at 6:51 AM Jan Beulich <jbeulich@suse.com> wrote:
>
> On 12.08.2024 15:26, H.J. Lu wrote:
> > --- /dev/null
> > +++ b/gas/testsuite/gas/i386/x86-64-macro-1.s
> > @@ -0,0 +1,7 @@
> > +     .macro WRAPPER_IMPL_SSE2 callee
> > +     call *\ callee@GOTPCREL(%rip)
> > +     .endm
> > +
> > +     .text
> > +_start:
> > +     WRAPPER_IMPL_SSE2 acos
>
> /If/ we really want such a test (applies similarly to the other one),
> then clearly some comment is needed. One shouldn't need to go back to
> the commit to find what's going on. (Right here I'm afraid I wouldn't
> be able to deduce what these seemingly broken tests are about even
> after having read the description).
>
> Plus surely this test doesn't need to be x86-specific. In fact you
> could simply fold it into ...

Since the assembler errors are different:

 Error: too many positional arguments

vs

 Error: invalid character '\' in operand 1

I will keep the x86-64 test.

>
> > --- /dev/null
> > +++ b/gas/testsuite/gas/macros/arg1.s
> > @@ -0,0 +1,7 @@
> > +     .macro test arg1
> > +     .byte \arg1
>
> ... here, adding a blank after the backslash (plus a comment clarifying
> what this is about).

I will add it.

> Jan



-- 
H.J.