[PATCH] aarch64: Add support for the fpmr system register

Victor Do Nascimento victor.donascimento@arm.com
Tue Apr 30 09:33:15 GMT 2024


Hi Claudio,

Patch looks good.  Any CI failures at this stage are to be expected, 
given how this patch is dependent on the upstreaming of my own FP8 patches.

Hopefully, once we have the relevant approval for this patch, we can 
push all FP8-related changes at once.  The idea behind pushing 
everything together comes from the fact that any FP8 work makes little 
sense without the necessary fpmr system-register enablement - which 
you've added here.

Thanks for doing this!
V.

On 4/26/24 16:00, Claudio Bantaloukas wrote:
> 
> AArch64 defines a read-write system register called fpmr.
> This floating point mode register controls behaviours of the FP8 instructions.
> This patch adds support for reading and writing along with relevant tests.
> Regression tested on the aarch64-none-elf and aarch64-none-linux-gnu targets
> and no regressions were found.
> 
> ---
> 
> Hi,
> 
> Is this Ok for master? I do not have commit rights, if OK, can someone commit on my behalf please?
> 
> Thanks,
> Claudio Bantaloukas
> 
>   .../gas/aarch64/sysreg/fp8-feature-enables-r.d    | 12 ++++++++++++
>   .../gas/aarch64/sysreg/fpmr-unsupported-by-default.d |  4 ++++
>   .../gas/aarch64/sysreg/fpmr-unsupported-by-default.l |  3 +++
>   gas/testsuite/gas/aarch64/sysreg/fpmr.s              |  4 ++++
>   opcodes/aarch64-sys-regs.def                         |  1 +
>   5 files changed, 24 insertions(+)
>   create mode 100644 gas/testsuite/gas/aarch64/sysreg/fp8-feature-enables-fpmr.d
>   create mode 100644 gas/testsuite/gas/aarch64/sysreg/fpmr-unsupported-by-default.d
>   create mode 100644 gas/testsuite/gas/aarch64/sysreg/fpmr-unsupported-by-default.l
>   create mode 100644 gas/testsuite/gas/aarch64/sysreg/fpmr.s
> 


More information about the Binutils mailing list