[PATCH] RISC-V: Add support for Zimop extension

Jan Beulich jbeulich@suse.com
Thu Apr 25 09:51:05 GMT 2024


On 25.04.2024 10:19, Xiao Zeng wrote:
> This implements the Zimop (May-Be-Operations) extension, as of version 1.0.
> 
> See
>   <https://github.com/riscv/riscv-isa-manual/blob/main/src/zimop.adoc>

Just two cosmetic remarks (nits) on the new testcase:

> --- /dev/null
> +++ b/gas/testsuite/gas/riscv/zimop.s
> @@ -0,0 +1,44 @@
> +target:
> +	# mop.r.n
> +        mop.r.0 a0, a1

Would be nice if insns and comments were indented the same.

> +        mop.r.1 a0, a1
> +        mop.r.2 a0, a1
> +        mop.r.3 a0, a1
> +        mop.r.4 a0, a1
> +        mop.r.5 a0, a1
> +        mop.r.6 a0, a1
> +        mop.r.7 a0, a1
> +        mop.r.8 a0, a1
> +        mop.r.9 a0, a1
> +        mop.r.10 a0, a1
> +        mop.r.11 a0, a1
> +        mop.r.12 a0, a1
> +        mop.r.13 a0, a1
> +        mop.r.14 a0, a1
> +        mop.r.15 a0, a1
> +        mop.r.16 a0, a1
> +        mop.r.17 a0, a1
> +        mop.r.18 a0, a1
> +        mop.r.19 a0, a1
> +        mop.r.20 a0, a1
> +        mop.r.21 a0, a1
> +        mop.r.22 a0, a1
> +        mop.r.23 a0, a1
> +        mop.r.24 a0, a1
> +        mop.r.25 a0, a1
> +        mop.r.26 a0, a1
> +        mop.r.27 a0, a1
> +        mop.r.28 a0, a1
> +        mop.r.29 a0, a1
> +        mop.r.30 a0, a1
> +        mop.r.31 a0, a1
> +	# mop.rr.n
> +        mop.rr.0 a0, a1, a2
> +        mop.rr.1 a0, a1, a2
> +        mop.rr.2 a0, a1, a2
> +        mop.rr.3 a0, a1, a2
> +        mop.rr.4 a0, a1, a2
> +        mop.rr.5 a0, a1, a2
> +        mop.rr.6 a0, a1, a2
> +        mop.rr.7 a0, a1, a2
> +        
> \ No newline at end of file

Please avoid such.

Jan


More information about the Binutils mailing list