[PATCH] arm: Fix MVE vmla encoding

[Claudio Bantaloukas]

On 4/23/2024 6:04 PM, Nick Clifton wrote:
> Hi Claudio,
> 
>> Is this Ok for master? I do not have commit rights, if OK, can someone 
>> commit on my behalf please?
>> Tested on arm-none-eabi.
> 
> Patch approved and applied.  I did have to make one change however.
> The patch, as it was, added a new failure to the gas testsuite
> for PE based ARM targets (eg arm-wince-pe):


Hi Nick,

thank you for picking this up and for the fix.

I checked the result of the builds linked from patchwork but those do 
not cover arm-none-eabi, and, to be honest, I didn't even realize wince 
is still supported!
Is there another system that would allow me to catch such an error?

>    gas/testsuite/gas/arm/mve-vmla.s:20: Error: unknown pseudo-op: 
> `.inst'>, no expected output
>    FAIL: MVE vmla instructions
> 
> The .inst pseudo-op is ELF specific, so that is why the failure was
> happening.  I choose the simplest solution of adding:
> 
>    #target: [is_elf_format]
> 
> to the mve-vmla.d test control file.  But you might prefer to make a
> more complete solution by moving the .inst directive out of the mve-vmla.s
> source file and into its own file...

I'm learning new things every day. Your solution is spot on as I highly 
doubt any processor with MVE will be supported by wince. It also looks 
more succinct compared to other tests that do similar things with the 
more extensive

	#notarget: *-*-*coff *-*-pe *-*-wince *-*-*aout* *-*-netbsd

> 
> Cheers
>    Nick
> 

-- 
Claudio Bantaloukas