[PATCH] gas: Fix a CFI label name memory leak in scfi.c
H.J. Lu
hjl.tools@gmail.com
Tue Apr 9 23:04:16 GMT 2024
CFI label name can be freed only after use.
* scfi.c (handle_scfi_dot_cfi): Free CFI label name after use.
* scfidw2gen.c (scfi_process_cfi_label): Add a comment. Remove
TODO on freeing CFI label name.
---
gas/scfi.c | 1 +
gas/scfidw2gen.c | 4 ++--
2 files changed, 3 insertions(+), 2 deletions(-)
diff --git a/gas/scfi.c b/gas/scfi.c
index 37cc85cfed7..f34150cb08a 100644
--- a/gas/scfi.c
+++ b/gas/scfi.c
@@ -1137,6 +1137,7 @@ handle_scfi_dot_cfi (ginsnS *ginsn)
break;
case CFI_label:
scfi_dot_cfi (CFI_label, 0, 0, 0, op->op_data->name, ginsn->sym);
+ free ((char *) op->op_data->name);
break;
case CFI_signal_frame:
scfi_dot_cfi (CFI_signal_frame, 0, 0, 0, NULL, ginsn->sym);
diff --git a/gas/scfidw2gen.c b/gas/scfidw2gen.c
index ebf2d24dab2..2b018fac8bd 100644
--- a/gas/scfidw2gen.c
+++ b/gas/scfidw2gen.c
@@ -57,8 +57,8 @@ scfi_process_cfi_label (void)
frch_ginsn_data_append (ginsn);
scfi_op_add_cfi_label (ginsn, name);
- /* TODO. */
- // free (name);
+ /* NB: Can't free NAME here since it will be used later. Free it in
+ handle_scfi_dot_cfi after it is unused. */
demand_empty_rest_of_line ();
}
--
2.44.0
More information about the Binutils
mailing list