[PATCH] Add support to readelf for the PT_OPENBSD_NOBTCFI segment type.
Frederic Cambus
fred@statdns.com
Thu Sep 28 11:05:14 GMT 2023
Hi Nick,
On Wed, Sep 27, 2023 at 02:38:25PM +0100, Nick Clifton wrote:
> Hi Frederic,
>
> Approved - please apply - but with one very small change:
>
> > #define PT_OPENBSD_WXNEEDED (PT_LOOS + 0x5a3dbe7) /* Program does W^X violations. */
> > +#define PT_OPENBSD_NOBTCFI (PT_LOOS + 0x5a3dbe8) /* no branch target CFI. */
> > #define PT_OPENBSD_BOOTDATA (PT_LOOS + 0x5a41be6) /* Section for boot arguments. */
>
> Please could you use a capital letter at the start of the comment. ie:
>
> > +#define PT_OPENBSD_NOBTCFI (PT_LOOS + 0x5a3dbe8) /* No branch target CFI. */
Thanks for the review. I don't have commit access, could you please
commit it for me?
More information about the Binutils
mailing list