[PATCH v1 1/1] opcodes: microblaze: Add wdc.ext.clear and wdc.ext.flush insns

Frager, Neal neal.frager@amd.com
Wed Sep 27 13:52:38 GMT 2023


Hi Nick,

> Added two new instructions, wdc.ext.clear and wdc.ext.flush, to enable 
> MicroBlaze to flush an external cache, which is used with the new 
> coherency support for multiprocessing.

> Patch approved and applied.

> One small question:

> +  {"wdc.ext.clear", INST_TYPE_R1_R2_SPECIAL, INST_NO_OFFSET, 
> + NO_DELAY_SLOT, IMMVAL_MASK_NON_SPECIAL, 0x90000466, 
> + OPCODE_MASK_H35B, wdcextclear, special_inst }

> This new line omits a comma at the end.  Was this deliberate ?

> I have assumed that it was just a typo and added one, but if there is a good reason to omit the comma, please let me know and I will correct the pushed patch.

Yes, you are correct.  Thank you for catching this typo and fixing it for me!

Best regards,
Neal Frager
AMD


More information about the Binutils mailing list