[PATCH v2 1/2] *: add modern gettext support

[Kevin Buettner]

On Tue, 26 Sep 2023 02:17:33 +0200
Arsen Arsenović via Binutils <binutils@sourceware.org> wrote:

>  gdb/acinclude.m4         |   3 +-
>  gdbsupport/Makefile.am   |   5 +
[...]
> diff --git a/gdb/acinclude.m4 b/gdb/acinclude.m4
> index 173e40b440a..d505fbbb267 100644
> --- a/gdb/acinclude.m4
> +++ b/gdb/acinclude.m4
> @@ -235,7 +235,8 @@ AC_DEFUN([GDB_AC_CHECK_BFD], [
>    # always want our bfd.
>    CFLAGS="-I${srcdir}/../include -I../bfd -I${srcdir}/../bfd $CFLAGS"
>    LDFLAGS="-L../bfd -L../libiberty $LDFLAGS"
> -  intl=`echo $LIBINTL | sed 's,${top_builddir}/,,g'`
> +  # LTLIBINTL because we use libtool as CC below.
> +  intl="$(echo "$LTLIBINTL" | sed 's,\$[[{(]top_builddir[)}]]/,,')"
>    LIBS="-lbfd -liberty $intl $LIBS"
>    CC="./libtool --quiet --mode=link $CC"
>    AC_CACHE_CHECK(
> diff --git a/gdbsupport/Makefile.am b/gdbsupport/Makefile.am
> index 00524e9a566..f1a641308fe 100644
> --- a/gdbsupport/Makefile.am
> +++ b/gdbsupport/Makefile.am
> @@ -20,6 +20,11 @@
>  AUTOMAKE_OPTIONS = no-dist foreign
>  ACLOCAL_AMFLAGS = -I . -I ../config
>  
> +# Suppress 'configure.ac: error: AM_GNU_GETTEXT used but SUBDIRS not defined'
> +# from Automake, as gdbsupport uses AM_GNU_GETTEXT through
> +# ZW_GNU_GETTEXT_SISTER_DIR, but doesn't have any translations (currently).
> +SUBDIRS =
> +
>  AM_CPPFLAGS = -I$(srcdir)/../include -I$(srcdir)/../gdb \
>      -I../gnulib/import -I$(srcdir)/../gnulib/import \
>      -I.. -I$(srcdir)/.. $(INCINTL) -I../bfd -I$(srcdir)/../bfd \

The GDB portions look reasonable to me, so those parts are approved.  You'll
still need to get approval for all of the other areas though.

Approved-by: Kevin Buettner <kevinb@redhat.com> (GDB portions only.)