[PATCH 2/2] *: suppress xgettext 0.22 charset name error

[Arsen Arsenović]

Andreas Schwab <schwab@suse.de> writes:

> On Sep 25 2023, Arsen Arsenović via Binutils wrote:
>
>> libctf/ChangeLog:
>>
>> 	* po/Make-in ($(srcdir)/$(PACKAGE).pot): Output to a .pot
>> 	temporary file to suppress xgettext checking charset names.
>
> There is no po/Make-in in libctf.

Seems to have been an error when I was filling the changelog entries.
The libctf changelog should be:

       * Makefile.am (SUBDIRS): Define to empty to suppress Automake
       stating 'configure.ac: error: AM_GNU_GETTEXT used but SUBDIRS not
       defined'

... which also covers your latter comment.

>
>> diff --git a/gdbsupport/Makefile.am b/gdbsupport/Makefile.am
>> index 00524e9a566..43aa670faf4 100644
>> --- a/gdbsupport/Makefile.am
>> +++ b/gdbsupport/Makefile.am
>> @@ -19,6 +19,7 @@
>>  
>>  AUTOMAKE_OPTIONS = no-dist foreign
>>  ACLOCAL_AMFLAGS = -I . -I ../config
>> +SUBDIRS =
>>  
>>  AM_CPPFLAGS = -I$(srcdir)/../include -I$(srcdir)/../gdb \
>>      -I../gnulib/import -I$(srcdir)/../gnulib/import \
>
> Spurious change.

This has the same rationale as the libctf change above. 

>> diff --git a/libctf/Makefile.am b/libctf/Makefile.am
>> index b1dbc2f6ba4..8c9f623f58c 100644
>> --- a/libctf/Makefile.am
>> +++ b/libctf/Makefile.am
>> @@ -17,6 +17,8 @@
>>  # <http://www.gnu.org/licenses/>.
>>  #
>>  
>> +SUBDIRS = 
>> +
>>  ACLOCAL_AMFLAGS = -I .. -I ../config -I ../bfd
>>  
>>  AUTOMAKE_OPTIONS = dejagnu foreign info-in-builddir no-texinfo.tex
>
> Likewise.

These directories utilize ZW_GNU_GETTEXT_SISTER_DIR to get information
about where gettext is despite never having any translations of their
own, leading to the Automake warning above. 

Apologies for the ChangeLog confusion, it must've been late when I was
splitting and merging commits, and so I mislabeled and mismerged some
changes.  I can split this patch into two if you agree, and fix the
libctf ChangeLog entry.

Thanks, have a lovely day.
-- 
Arsen Arsenović
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 381 bytes
Desc: not available
URL: <https://sourceware.org/pipermail/binutils/attachments/20230925/f840fc02/attachment-0001.sig>