[PATCH 4/8] Support APX NDD

[Cui, Lili]

> Subject: Re: [PATCH 4/8] Support APX NDD
> 
> On 19.09.2023 17:25, Cui, Lili wrote:
> > --- a/opcodes/i386-dis-evex-prefix.h
> > +++ b/opcodes/i386-dis-evex-prefix.h
> > @@ -353,8 +353,8 @@
> >    /* PREFIX_EVEX_MAP4_66 */
> >    {
> >      { MOD_TABLE (MOD_EVEX_MAP4_66_PREFIX_0) },
> > -    { "adoxS",	{ Gdq, Edq }, 0 },
> > -    { "adcxS",	{ Gdq, Edq }, 0 },
> > +    { "adoxS",	{ VexGdq, Gdq, Edq }, 0 },
> > +    { "adcxS",	{ VexGdq, Gdq, Edq }, 0 },
> 
> With the OP_VEX() change moved to the earlier patch, you wouldn't need to
> alter again right away what was just added there.
>
Hi Jan,

I just wanted to move the instructions in EVEX involving NDD into this patch. I think they should belong to this NDD patch.  As in your second comment, I also found some instructions for the disassembler missing in the APX evex patch. 

Lili.

> > --- a/opcodes/i386-dis-evex-reg.h
> > +++ b/opcodes/i386-dis-evex-reg.h
> > @@ -56,6 +56,105 @@
> >      { "blsmskS",	{ VexGdq, Edq }, 0 },
> >      { "blsiS",		{ VexGdq, Edq }, 0 },
> >    },
> > +  /* REG_EVEX_MAP4_80 */
> > +  {
> > +    { "addA",	{ VexGb, Eb, Ib }, 0 },
> > +    { "orA",	{ VexGb, Eb, Ib }, 0 },
> > +    { "adcA",	{ VexGb, Eb, Ib }, 0 },
> > +    { "sbbA",	{ VexGb, Eb, Ib }, 0 },
> 
> Aren't these two and other adc/sbb entries required already in the earlier
> patch, for consistency with what you add there on the assembler side?
>