[PATCH v6 1/2] opcodes: microblaze: Add new bit-field instructions

Frager, Neal neal.frager@amd.com
Fri Oct 20 06:28:05 GMT 2023


Hi Alan,


> Le 19 oct. 2023 à 23:30, Alan Modra <amodra@gmail.com> a écrit :
> 
> On Thu, Oct 19, 2023 at 01:20:03PM +0000, Frager, Neal wrote:
>> Could you please test the following patch?  On my side, it resolves the issue you are reporting.
>> 
>> https://patchwork.sourceware.org/project/binutils/patch/20231019113740.2071556-1-neal.frager@amd.com/
> 
> It does.  I saw the email yesterday and thought, "good, he's fixed the
> obvious NUM_STRBUFS bug which was the source of the abort, and also
> the .short thing".
> 
> --
> Alan Modra
> Australia Development Lab, IBM

The original patch I submitted was just copy pasting from our meta-xilinx patch set.  I am actually quite surprised such a bug exists since AMD has been shipping a microblaze toolchain with this bug in it for a few years now.

And now that I am looking more closely at the microblaze-opc.h file, I think there are probably quite a few issues with disassembly and the objdump utility which need fixing.

If you catch any other issues, please let me know, as I would like to get this cleaned up.

Best regards,
Neal Frager
AMD


More information about the Binutils mailing list