FW: [PATCH 3/8] Add tests for APX GPR32 with extend evex prefix

[Jan Beulich]

On 17.10.2023 17:53, Cui, Lili wrote:
>>> --- a/gas/testsuite/gas/i386/x86-64-inval-movbe.s
>>> +++ b/gas/testsuite/gas/i386/x86-64-inval-movbe.s
>>> @@ -1,5 +1,6 @@
>>>  # Check illegal movbe in 64bit mode.
>>>  	.text
>>> +	.arch .noapx_f
>>>  foo:
>>>  	movbe	(%rcx),%bl
>>>  	movbe	%ecx,%ebx
>>
>> I don't understand the need for this addition (and hence for the need to
>> change the test's expecations). Like was mentioned on the original
>> AVX10 series, tests like this shall not need modification, or else it indicates
>> people's code also may need ".arch .noapx_f" additions, which I'm sure you
>> agree may not be required. Finally, if testcase expecations like the above
>> would be needed anywhere, please generalize them such that a similar mere
>> addition of a line doesn't require the entire test to be touched. Here this
>> means that while for the diagnostics you of course want exact line number
>> matches, for the actual listing line numbers don't don't need matching
>> individually.
>>
> 
> Agree with you, but movbe is special, movbe didn't support reg to reg before, but APX enable it. so I added .arch .noapx_f for this invalid test.

To be honest I didn't really notice this difference so far. That's somewhat
ugly, because people mistakenly using a reg->reg form would suddenly get an
EVEX encoding rather than an error. This will need some further thought;
please mention the "anomaly" explicitly in the description of the respective
patch.

Jan