Re: ☠ Buildbot (Sourceware): binutils-gdb - failed compile (failure) (master)

[Clément Chigot]

This is mine. Not sure why I don't have the error message locally
though. Maybe something with -Werror. I'll push the following fix:

Author: Clément Chigot <chigot@adacore.com>
Date:   Fri Oct 13 16:43:32 2023 +0200

    ld: replace wrong bfd_malloc in nto.em

    xmalloc should be used in emultation template instead of bfd_malloc.

    ld/ChangeLog:

            * emultempl/nto.em (nto_lookup_QNX_note_section): Replace
            bfd_malloc by xmalloc.

diff --git a/ld/emultempl/nto.em b/ld/emultempl/nto.em
index f4c76f18fc2..273502dd802 100644
--- a/ld/emultempl/nto.em
+++ b/ld/emultempl/nto.em
@@ -98,7 +98,7 @@ nto_lookup_QNX_note_section(int type)
        continue;

       /* Verify that this is a QNX note of the expected type.  */
-      sec->contents = bfd_malloc(sec->size);
+      sec->contents = xmalloc(sec->size);
       if (!bfd_get_section_contents (sec->owner, sec, sec->contents,
(file_ptr) 0,
                                     sec->size))
        einfo (_("%F%P: %pB: can't read contents of section .note: %E\n"),

Sorry about the trouble
Clément