[PATCH 1/8] Support APX GPR32 with rex2 prefix

Cui, Lili lili.cui@intel.com
Sat Oct 7 03:27:45 GMT 2023


> >> I don't think "ignored" is what you mean, considering ...
> >>
> >>>      /* MOD_0FAE_REG_5 */
> >>> -    { "xrstor",		{ FXSAVE }, PREFIX_OPCODE },
> >>> +    { "xrstor",		{ FXSAVE }, PREFIX_OPCODE |
> >> PREFIX_IGNORED_REX2 },
> >>>      { PREFIX_TABLE (PREFIX_0FAE_REG_5_MOD_3) },
> >>>    },
> >>
> >> ... these uses here.
> >>
> >
> > Replaced " PREFIX_IGNORED_REX2" with "ILLEGAL_PREFIX_REX2 ".
> 
> May I ask that we keep PREFIX_ first, i.e. PREFIX_ILLEGAL_REX2 (or
> PREFIX_REX2_ILLEGAL)?
> 
Well, I prefer PREFIX_REX2_ILLEGAL.

> > Finally, thank you for checking these large patches so carefully. The next few
> days are China's national holidays, which last about 8 days, my feedback time
> will be longer. Thank you.
> 
> Oh, that fits nicely with me taking vacation the next two weeks.
> 

Glad to hear that and have a good vacation!

Lili.




More information about the Binutils mailing list