[PATCH 0/2] testsuite: Clean up i386 tests
Jiang, Haochen
haochen.jiang@intel.com
Mon Nov 27 09:07:08 GMT 2023
> -----Original Message-----
> From: Jan Beulich <jbeulich@suse.com>
> Sent: Monday, November 27, 2023 5:03 PM
> To: Jiang, Haochen <haochen.jiang@intel.com>
> Cc: hjl.tools@gmail.com; binutils@sourceware.org
> Subject: Re: [PATCH 0/2] testsuite: Clean up i386 tests
>
> On 27.11.2023 09:43, Haochen Jiang wrote:
> > Hi all,
> >
> > I just have some time to do some clean up to remove the redundant
> > #as in dump files and directive .allow_index_reg for i386 tests.
> >
> > Both regtested on x86-64-linux. Ok for trunk?
>
> Both okay, and thanks for taking the time. In patch 2 I would have
> preferred if you had taken the opportunity and remove specific line
> expectations from listing output (e.g. mpx-inval-1.l), by using
> [0-9]+ instead for the line number parts. But I'm not going to insist
> that you touch these again.
Actually I am considering this change since there are also other tests
using the specific line numbers. When a line got deleted, all the line
number are disturbed, which is quite annoying when adjusting testcases.
If I have some time and find an easy way to change all of them, I will
do that.
Thx,
Haochen
>
> Jan
More information about the Binutils
mailing list