[PATCH 6/8] Support APX Push2/Pop2

Cui, Lili lili.cui@intel.com
Wed Nov 22 12:26:52 GMT 2023


> >>> --- a/gas/testsuite/gas/i386/x86-64-apx-evex-promoted-bad.s
> >>> +++ b/gas/testsuite/gas/i386/x86-64-apx-evex-promoted-bad.s
> >>> @@ -30,3 +30,9 @@ _start:
> >>>          .byte 0xff
> >>>          #{evex} inc %rax EVEX.vvvv' > 0 (illegal value).
> >>>          .byte 0x62, 0xf4, 0xec, 0x08, 0xff, 0xc0
> >>> +        .byte 0xff, 0xff
> >>> +	# pop2 %rax, %rbx set EVEX.ND=0.
> >>> +        .byte 0x62,0xf4,0x64,0x08,0x8f,0xc0
> >>> +        .byte 0xff, 0xff, 0xff
> >>> +	# pop2 %rax, %rsp set EVEX.VVVV=0xf.
> >>> +        .byte 0x62,0xf4,0x7c,0x18,0x8f,0xc0
> >>
> >> This 2nd comment looks bogus. What is it that's being tested here?
> >>
> >
> > I think it should be  # pop2 %rax set EVEX.vvvv' = 1111. It wants to test that
> pop2 has only one operand when decoding.
> 
> But POP2 has two operands, one encoded in EVEX.vvvv. The use of %rsp as an
> operand is what I would think is being tested here, but then I don't see why
> the comment mentions EVEX.vvvv.
> 

Ok, I changed it to test %rsp.

Thanks,
Lili.


More information about the Binutils mailing list