[PATCH 6/8] Support APX Push2/Pop2

[Jan Beulich]

On 08.11.2023 12:44, Jan Beulich wrote:
> On 02.11.2023 12:29, Cui, Lili wrote:
>> @@ -6854,6 +6858,24 @@ check_VecOperands (const insn_template *t)
>>  	}
>>      }
>>  
>> +  /* Push2/Pop2 cannot use RSP and Pop2 cannot pop two same registers.  */
>> +  if (t->opcode_modifier.push2pop2)
> 
> I question this way of recognizing these two insns: You introduce a
> whole new table column here just to have two entries set this bit.
> This is cheaper by comparing the mnemonic offsets, as we do elsewhere
> in various cases.

Well, it's 4 rows, not 2, so the mnemonic offset suggestion isn't quite
nice. But there still is no need for a whole new attribute. Just another
OperandConstraint value ought to do.

Jan