Commit: ld x86_64 tests: Accept x86-64-v3 as a needed ISA

Nick Clifton nickc@redhat.com
Mon Nov 6 14:22:22 GMT 2023


Hi Jan,

> In the course of making the adjustment I already needed to switch .S to .s
> files, as the ld-as-linker tests want to use gas directly, not go via the
> C compiler (unless I overlooked some way to achieve the latter nevertheless).
> Hence #include-ing a common header just won't work.

Fair enough.

> I certainly agree that comments would be nice to add, but in git what I
> sent you will show up as a rename rather than deletion + creation of a new
> file, and hence you would observe that within the files only the first few
> lines actually changed. Everything else is simply kept as it was. I'll go
> and add such comments, 

Thanks.

> but any kind of rework of the involved source files
> will increase the barrier towards also addressing the same latent issues
> elsewhere. (Albeit, as indicated earlier, I think it would be best anyway
> if H.J. cleaned up all of this, once he's back.)

Noted.


The patched tests (and reverted test regexps) do work in my local x86-64-v3
environment, so your change is looking good to me.

Cheers
   Nick




More information about the Binutils mailing list