Commit: ld x86_64 tests: Accept x86-64-v3 as a needed ISA

Jan Beulich jbeulich@suse.com
Thu Nov 2 13:06:52 GMT 2023


On 02.11.2023 14:00, Nick Clifton wrote:
>> Oh, no, me being suspicious isn't because of the way you've expressed
>> things. Instead you've broken the intended purpose of the test, I'm
>> afraid: What this is about - iiuc - is to check that the linker
>> correctly folds the respective notes from, in particular,
>> property-x86-1.o and property-x86-2.o. Relaxing the expectations as you
>> did means e.g. a bug in the linker wrongly folding v2+v4 into v2+v3+v4
>> would now go unnoticed.
> 
> Ah! I see now.  Yes you are correct.
> 
>> In any event I'm of the opinion that the change wants reverting.
> 
> And the tests changed so that they do not involve any system object
> files at all, right ?
> 
> Are you volunteering ?  :-)  If not then I will have a go myself.

Well, preferably I'd like to "volunteer" H.J., as he introduced all this
machinery. Just that afaik he won't be around until the end of the month.
I wouldn't be able to tell when I might get around to try dealing with
this; not before end of next week for sure.

Jan



More information about the Binutils mailing list