Commit: ld x86_64 tests: Accept x86-64-v3 as a needed ISA

[Jan Beulich]

On 02.11.2023 10:57, Nick Clifton wrote:
> Hi Guys,
> 
>   Recently four of the x86_64 linker tests have started failing for the 
>   Fedora rawhide binutils because the x86_64-v3 ISA is being used and
>   .note.gnu.property notes show:
> 
>     x86 ISA needed: x86-64-baseline, x86-64-v2, x86-64-v3

Where's that coming from? At least ...

> --- a/ld/testsuite/ld-x86-64/property-3.r
> +++ b/ld/testsuite/ld-x86-64/property-3.r
> @@ -4,5 +4,5 @@ Displaying notes found in: .note.gnu.property
>    GNU                  0x[0-9a-f]+	NT_GNU_PROPERTY_TYPE_0
>        Properties: stack size: 0x800000
>  #...
> -	x86 ISA needed: x86-64-baseline, x86-64-v2
> +	x86 ISA needed: x86-64-baseline, x86-64-v2.*

... this change is suspicious at the first glance, as it raises the ISA
requirements for the resulting object. That shouldn't happen by default.

> --- a/ld/testsuite/ld-x86-64/property-4.r
> +++ b/ld/testsuite/ld-x86-64/property-4.r
> @@ -4,5 +4,5 @@ Displaying notes found in: .note.gnu.property
>    GNU                  0x[0-9a-f]+	NT_GNU_PROPERTY_TYPE_0
>        Properties: stack size: 0x800000
>  #...
> -	x86 ISA needed: x86-64-baseline, x86-64-v2, x86-64-v4
> +	x86 ISA needed: x86-64-baseline, x86-64-v2,.*x86-64-v4
>  #pass
> --- a/ld/testsuite/ld-x86-64/property-5.r
> +++ b/ld/testsuite/ld-x86-64/property-5.r
> @@ -4,5 +4,5 @@ Displaying notes found in: .note.gnu.property
>    GNU                  0x[0-9a-f]+	NT_GNU_PROPERTY_TYPE_0
>        Properties: stack size: 0x900000
>  #...
> -	x86 ISA needed: x86-64-baseline, x86-64-v2, x86-64-v4
> +	x86 ISA needed: x86-64-baseline, x86-64-v2,.*x86-64-v4
>  #pass

For these I wonder whether we should really demand v2 in the expectations.
It's the highest only which matters, so checking for just v4 ought to be
enough. H.J., can you please clarify what the original intentions here
were?

Jan