[PATCH v3] Support Intel FRED LKGS

Zhang, Jun jun.zhang@intel.com
Fri May 26 10:02:55 GMT 2023


> -----Original Message-----
> From: Jan Beulich <jbeulich@suse.com>
> Sent: Friday, May 26, 2023 4:15 PM
> To: Zhang, Jun <jun.zhang@intel.com>
> Cc: hjl.tools@gmail.com; binutils@sourceware.org
> Subject: Re: [PATCH v3] Support Intel FRED LKGS
> 
> On 22.05.2023 16:20, Zhang, Jun wrote:
> > Hi all,
> >
> > This patch is the third version about Intel FRED and LKGS instructions.
> > please help to review.
> >
> > Jan,I am new comer, this is my first patch for binutils.
> > Maybe we need senior engineer to fix Ew.
> >
> > BRs,
> > Jun
> >
> > gas/ChangeLog:
> >
> >         * NEWS: Support Intel FRED LKGS.
> >         * config/tc-i386.c: Add fred lkgs
> >         * doc/c-i386.texi: Document .fred, .lkgs.
> >         * testsuite/gas/i386/i386.exp: Add FRED LKGS tests
> >         * testsuite/gas/i386/x86-64-fred-intel.d: Ditto.
> 
> This and ...
> 
> >         * testsuite/gas/i386/x86-64-fred.d: Ditto.
> >         * testsuite/gas/i386/x86-64-fred.s: Ditto.
> >         * testsuite/gas/i386/x86-64-lkgs-intel.d: Ditto.
> 
> ... this test ...
> 
> > --- a/gas/testsuite/gas/i386/i386.exp
> > +++ b/gas/testsuite/gas/i386/i386.exp
> > @@ -1189,6 +1189,9 @@ if [gas_64_check] then {
> >      run_dump_test "x86-64-amx-complex-intel"
> >      run_dump_test "x86-64-amx-complex-bad"
> >      run_list_test "x86-64-amx-complex-inval"
> > +    run_dump_test "x86-64-fred"
> > +    run_dump_test "x86-64-lkgs"
> > +    run_list_test "x86-64-lkgs-inval"
> >      run_dump_test "x86-64-clzero"
> >      run_dump_test "x86-64-mwaitx-bdver4"
> >      run_list_test "x86-64-mwaitx-reg"
> 
> .. aren't used. Both either want actually enabling or (less likely) deleting.

Sorry, I will submit a patch to fix it.

> 
> Jan


More information about the Binutils mailing list