[PATCH v3] Support Intel FRED LKGS

[Jan Beulich]

On 22.05.2023 16:20, Zhang, Jun wrote:
> This patch is the third version about Intel FRED and LKGS instructions.
> please help to review.
> 
> Jan,I am new comer, this is my first patch for binutils.
> Maybe we need senior engineer to fix Ew.  

Well, okay, I'll try to deal with that myself then. What I'm puzzled by
though is what this v3 is intended to change / correct comparing to v2.
The one small request about ...

> --- a/opcodes/i386-opc.tbl
> +++ b/opcodes/i386-opc.tbl
> @@ -3351,3 +3351,17 @@ aor, 0xf20f38fc, RAO_INT, Modrm|IgnoreSize|CheckOperandSize|NoSuf, { Reg32|Reg64
>  axor, 0xf30f38fc, RAO_INT, Modrm|IgnoreSize|CheckOperandSize|NoSuf, { Reg32|Reg64, Dword|Qword|Unspecified|BaseIndex }
>  
>  // RAO-INT instructions end.
> +
> +// LKGS instructions.

... using singular here and ...

> +lkgs, 0xf20f00/6, LKGS|x64, Modrm|IgnoreSize|No_bSuf|No_sSuf|NoRex64, { Reg16|Reg32|Reg64 }
> +lkgs, 0xf20f00/6, LKGS|x64, Modrm|IgnoreSize|No_bSuf|No_lSuf|No_sSuf|No_qSuf, { Word|Unspecified|BaseIndex }
> +
> +// LKGS instructions end.

... here was not fulfilled, in any event. Plus that wouldn't require
re-posting, but simply correcting before/while committing. In case
you don't have commit access (you didn't say so, though) I'm sure
H.J. or I could make this small adjustment while committing for you.
But you'd need to let us know ...

Jan