[PATCH v2 0/5] Some MIPS changes and testsuite fixes

[Alan Modra]

On Tue, May 16, 2023 at 10:54:21AM +0800, YunQiang Su wrote:
> Run testsuite with targets:                            
>         mipsisa32-linux-gnu mipsisa32r2-linux-gnu mips-linux-gnu                                                       
>         mipsisa32el-linux-gnu mipsisa32r2el-linux-gnu mipsel-linux-gnu
>         mipsisa32r6-linux-gnu mipsisa32r6el-linux-gnu  
>         mips-img-linux-gnu mipsel-img-linux-gnu        
>         mips-img-elf mipsel-img-elf                    
>         mips-mti-elf mipsel-mti-elf                    
>         mips64-linux-gnu mips64el-linux-gnu            
>         mipsisa64-linux-gnu mipsisa64el-linux-gnu      
>         mipsisa64r2-linux-gnu mipsisa64r2el-linux-gnu  
>         mipsisa64r6-linux-gnu mipsisa64r6el-linux-gnu  
>         mips64el-linux-gnuabi64 mips64-linux-gnuabi64  
>         mipsisa64-linux-gnuabi64 mipsisa64el-linux-gnuabi64 
>         mipsisa64r2el-linux-gnuabi64 mipsisa64r2-linux-gnuabi64
>         mipsisa64r6el-linux-gnuabi64 mipsisa64r6-linux-gnuabi64

I applied your patchset and ran my usual regression tests over some
165 different binutils targets.  mipsisa32r2el-elf, mips-sgi-irix6,
and mipstx39-elf show some new failures.  This doesn't mean I
disapprove the patch, in fact I like it!  Please don't think you must
post another version of the patchset to fix these problems.  It might
be better to solve them with an incremental patch, giving the mips
maintainers a chance to review this patchset first.

Most of the mipsisa32r2el-elf fails are like this:
failed with: <Assembler messages:
Fatal error: selected target format 'elf32-nlittlemips' unknown>
FAIL: MIPS RM7000 workarounds test 2 (micromips)

Similarly, mipstx39-elf fails with
Fatal error: selected target format 'elf32-nbigmips' unknown

This one (one of the two mips-sgi-irix6 fails I saw) also appear with
mipsisa32r2el-elf and mips-sgi-irix6:
mips-sgi-irix6  +FAIL: MIPS ELF o32 PIC comdat GOT16/LO16 relocation pairing

regexp_diff match failure
regexp "^0000000c  0000070a R_MIPS_PC16       00000020   \.L1\^B1$"
line   "0000000c  00000d0a R_MIPS_PC16       00000020   .L1^B1"
regexp_diff match failure
regexp "^00000020  0000080a R_MIPS_PC16       00000018   \.L0\^B1$"
line   "00000020  00000e0a R_MIPS_PC16       00000018   .L0^B1"
FAIL: MIPS ELF o32 PIC comdat GOT16/LO16 relocation pairing

So that one is caused by different symbol table ordering.

-- 
Alan Modra
Australia Development Lab, IBM