[PATCH] MIPS: fix loongson3 llsc workaround

Maciej W. Rozycki macro@orcam.me.uk
Thu May 11 00:00:32 GMT 2023


On Thu, 23 Mar 2023, YunQiang Su wrote:

> -mfix-looongson3-llsc may add sync instructions not needed on some
> asm code with lots of debug info.

 I can see the change has been committed, but who has actually reviewed 
it?

 The change description doesn't say what the change actually does, so one 
can't say whether it is correct or not.  At least an example of incorrect 
code produced ought to be shown and how the change affects it.  As it 
stands I have no idea what is going on here, and surely no one who looks 
at it in a few year's time will.

 Change descriptions cannot be retrofitted, so I think the original fix 
ought to be reverted and, assuming it is indeed the correct one, reapplied 
with a correct change description (after a proper review).

  Maciej


More information about the Binutils mailing list