[PATCH] optimize handle_COMDAT
Oleg Tolmatcev
oleg.tolmatcev@gmail.com
Thu May 4 17:33:25 GMT 2023
Am Do., 4. Mai 2023 um 06:11 Uhr schrieb Alan Modra <amodra@gmail.com>:
>
> On Sat, Apr 29, 2023 at 02:39:00PM +0200, Oleg Tolmatcev via Binutils wrote:
> > Thanks for the review. Here is a new version.
>
> The patch you posted to the list is truncated, and the patch you sent
> me privately was somehow corrupted, with tabs being replaced with 4
> spaces and the single space lines in the patch being replaced with an
> empty line. Please fix your email client and/or editor. I applied it
> by hand, and found
>
> FAIL: Build pe-x86-64-1
> FAIL: Build pe-x86-64-2
> FAIL: Build pe-x86-64-3
> FAIL: Build pe-x86-64-6
>
> when running the testsuite on an x86_64-linux build. This is not
> acceptable. I also see you have ripped out more than just a little
> sanity checking and other code you didn't understand. Do you expect
> Nick or I to fix your patches for you?
Thanks for the review Alan. No I do not. It is my first time trying to
contribute, which is why I made mistakes. I am sorry.
More information about the Binutils
mailing list