[PATCH] add section caches to coff_data_type

Nick Clifton nickc@redhat.com
Thu May 4 11:29:46 GMT 2023


Hi Oleg,

> final patch to ld. All the patches together improve linking
> performance from 9 minutes to 1 minute when linking rpcs3 in debug
> mode with BUILD_LLVM=ON.

Unfortunately there are two problems with this patch:

   1.  It does not initialise the new fields in the coff_tdata
       structure for targets that just use the COFF file format
       rather than the PE file format.  (ie you need to duplicate
       the patch to peicode.h in the coffcode.h file).

   2.  (Actually more important): We either need a copyright
       assignment from you, or else you need to sign off on the
       patch before we can accept it.  To assign the copyright
       you should fill out one of the forms here and then send
       it off to the FSF:

https://git.savannah.gnu.org/gitweb/?p=gnulib.git;a=tree;f=doc/Copyright;h=22db9a802b4da96ad455cd933351c1359108f95d;hb=HEAD

       Alternatively you can attach a developer's certificate of
       origin to your patch, which is easier in the short term, but
       does need to be done with every patch submission.  More details
       here:

https://sourceware.org/binutils/wiki/HowToContribute

Cheers
   Nick

PS.  For your other two patches, I decided to treat them as "obvious"
   so no copyright assignment or DCO was needed.



More information about the Binutils mailing list