[PATCH RESEND] elfedit: add support for editing e_flags

Jan Beulich jbeulich@suse.com
Thu Mar 2 09:02:51 GMT 2023


On 02.03.2023 09:58, Jan Beulich via Binutils wrote:
> On 02.03.2023 09:14, WANG Xuerui wrote:
>> +	  tmp = strtoul (optarg, &end, 0);
>> +	  if (*end != '\0' || tmp > 0xffffffff)
> 
> I'm afraid this may trigger compiler warnings: For one because the constant
> isn't flagged as unsigned. And then (for 32-bit targets) for being an
> always-true comparison.

Argh, always-false (but you get the point).

Jan


More information about the Binutils mailing list