[PATCH V3] optimize handle_COMDAT

Nick Clifton nickc@redhat.com
Fri Jun 30 12:08:39 GMT 2023


Hi Oleg,

> I have improved my patch again. This time I read the MS COFF documentation, I kept all the checks, I successfully ran "make check" in WSL and I formatted the code with clang-format. I used the GNU style and tabs for indentation. I also simplified the patch.

Thank you.  Unfortunately there are still a couple of problems
with the patch,  Firstly, and most importantly, the patch triggers
a new failure in the linker testsuite:

   Running ld/testsuite/ld-linkonce/linkonce.exp ...
   [...]
   FAIL: pr26103


Secondly - the patch cannot be applied from your email.  Its formatting
has been corrupted, forcing me to apply it by hand.

Lastly the patch includes a lot of unnecessary formatting changes to
unrelated code.  This is annoying as it masks the true content of the
patch.

Please could you investigate the testsuite failure and submit a revised
patch as an attachment, rather than inline in the email.

Cheers
   Nick





More information about the Binutils mailing list