[PATCH] section-match: Check parent archive name as well

Nick Clifton nickc@redhat.com
Wed Jun 28 08:50:04 GMT 2023


Hi Michael,

>> Looks good, but please could also update the documentation so that
>> this use is explicitly cited as being supported ?
> 
> Actually, I'm reluctant to do that and would like to keep this
> undocumented.  We wouldn't be able to fix the FIXMEs in
> walk_wild_file_in_exclude_list anymore if such usage was documented, and
> we have a different (documented) way to specify what the user wanted.
> 
> In either case that should be a separate and conscious patch as it
> would introduce (formally) new behaviour.  If you still want me to amend
> the patch with a documentation change, I will, but only on second request
> ;-)

Fair enough.


>> Also would you mind adding a link to your post to this list to
>> the PR 30590 so that anyone reading that bug report can see how
>> you fixed it.  Thanks
>>
>>    https://sourceware.org/bugzilla/show_bug.cgi?id=30590
> 
> Oh yes, I haven't yet seen that a bugzilla entry was created for that.
> The commit will have it.

Great - patch approved - please apply.

Cheers
   Nick

PS. A patch to add a test for this bug to the linker testsuite is pre-approved,
   should you feel like writing one ....



More information about the Binutils mailing list