[PATCH v2 2/3] Add rotation instructions to MIPS Allegrex CPU

[Maciej W. Rozycki]

On Wed, 14 Jun 2023, david@davidgf.es wrote:

> The Allegrex CPU supports bit rotation instructions as described in the
> MIPS32 release 2 CPU (even though it is a MIPS-2 based CPU).

 Just a minor nit about this version.

> diff --git a/gas/testsuite/gas/mips/mips.exp b/gas/testsuite/gas/mips/mips.exp
> index 6dbf2e3746..f4137c5640 100644
> --- a/gas/testsuite/gas/mips/mips.exp
> +++ b/gas/testsuite/gas/mips/mips.exp
> @@ -517,7 +517,7 @@ mips_arch_create r3000 	32	mips1	{} \
>  mips_arch_create r3900 	32	mips1	{ gpr_ilocks } \
>  			{ -march=r3900 -mtune=r3900 } { -mmips:3900 } \
>  			{ mipstx39-*-* mipstx39el-*-* }
> -mips_arch_create allegrex 	32	mips2	{ oddspreg singlefloat } \
> +mips_arch_create allegrex 	32	mips2	{ oddspreg ror singlefloat } \

 You haven't reordered `ror' here as requested with v1.  I have done this 
for you (and fixed the order for `singlefloat' in 1/3 too, which I missed 
previously), but please be more careful in the future.  It helps when the 
reviewer doesn't have to double-check everything.

 I have now committed this change with said modification applied.  Thank 
you for your contribution.

  Maciej