[PATCH 2/2] MIPS: fix Irix gas testcases
Maciej W. Rozycki
macro@orcam.me.uk
Mon Jun 5 23:38:14 GMT 2023
On Mon, 5 Jun 2023, YunQiang Su wrote:
> 1. add -mpdr to some cases.
> gas doesn't generate .pdr section for Irix objects by default. See
> `int mips_flag_pdr` in tc-mips.c.
Non-PDR variants of the respective dumps need to be added then, veryfying
that PDR data is not produced where applicable. We have prior art in the
testsuite for such arrangements; cf. ${imips}. This can be reused for all
IRIX psABI targets.
> 2. disable call-nonpic-1 for Irix.
> gas doesn't set O32 flags for Irix objects in e_flags. See
> `use_e_mips_abi_o32` in gas/configure.ac.
This needs to be verified then too.
> 3. mips16-e.d: g1 may be marked as O.
> The Irix 5 and 6 assemblers set the type of any common symbol and
> any undefined non-function symbol to STT_OBJECT.
> See `mips_frob_symbol` in tc-mips.c.
This is minor enough, so probably OK. It might be worth checking if it's
covered elsewhere.
Please use correct capitalisation; in English sentences start with a
capital letter. Also use two spaces after every full stop as per the GNU
Coding Standards. This applies both to change headings/descriptions and
pieces of text included with the change proper.
Maciej
More information about the Binutils
mailing list