[PATCH] gas: rework timestamp preservation on doc/asconfig.texi

Nick Clifton nickc@redhat.com
Mon Jul 31 14:29:55 GMT 2023


Hi Jan,

> PR 28909
> 
> Sadly "cp -p", doing more than just preserving the time stamp, can fail
> e.g. upon trying to preserve ownership (which we don't care about), as
> can be observed on e.g. Cygwin. Replace the use of -p by a use of touch,
> this way also only preserving modification time.

Thanks for fixing this.  If you have not done so already, please also apply
the patch to the 2.41 branch.


> Interestingly that earlier commit (8034b0baeac1) looks to also be the
> reason of there now being "GEN    doc/asconfig.texi" on every
> (incremental) rebuild.

Strange, I thought that the point was to avoid this kind of thing.

> Would be nice if that could be avoided. 

Rebuilding does not take that long though, does it ?

> How
> important is it to actually retain the timestamp? Said commit said
> nothing on the "Why" aspect ... The issue described in the bug doesn't
> look like it wants dealing with by using "cp -p" (or alike).

Well as I understood it, the point was that using "cp -p" meant that the
timestamps on the doc/asconfig.tex and doc/asconfig.texi files would
always be the same, so the build system would not decide to rebuild the
documentation and hence there would be no problem if the makeinfo program
was not available.

Cheers
   Nick



More information about the Binutils mailing list