[committed 09/16] MIPS/GAS/testsuite: Force o32 for tests expecting 32-bit addressing

Maciej W. Rozycki macro@orcam.me.uk
Fri Jul 28 05:07:12 GMT 2023


From: YunQiang Su <yunqiang.su@cipunited.com>

A few GAS tests expect to be assembled with 32-bit addressing, otherwise 
causing an assembly warning:

.../gas/testsuite/gas/mips/fix-rm7000-2.s:11: Warning: la used to load 64-bit address; recommend using dla instead

or pattern dump mismatches against 32-bit address calculations, however 
these tests do not enforce their expectation in any.  For none of them 
the specific ABI used is of any relevance however, so select the o32 ABI
unconditionally, removing these failures with OpenBSD targets:

mips64-openbsd  -FAIL: MIPS RM7000 workarounds test 2 (micromips)
mips64-openbsd  -FAIL: MIPS RM7000 workarounds test 2 (mips3)
mips64-openbsd  -FAIL: MIPS RM7000 workarounds test 2 (mips4)
mips64-openbsd  -FAIL: MIPS RM7000 workarounds test 2 (mips5)
mips64-openbsd  -FAIL: MIPS RM7000 workarounds test 2 (mips64)
mips64-openbsd  -FAIL: MIPS RM7000 workarounds test 2 (mips64r2)
mips64-openbsd  -FAIL: MIPS RM7000 workarounds test 2 (mips64r3)
mips64-openbsd  -FAIL: MIPS RM7000 workarounds test 2 (mips64r5)
mips64-openbsd  -FAIL: MIPS RM7000 workarounds test 2 (octeon)
mips64-openbsd  -FAIL: MIPS RM7000 workarounds test 2 (octeon2)
mips64-openbsd  -FAIL: MIPS RM7000 workarounds test 2 (octeon3)
mips64-openbsd  -FAIL: MIPS RM7000 workarounds test 2 (octeonp)
mips64-openbsd  -FAIL: MIPS RM7000 workarounds test 2 (r4000)
mips64-openbsd  -FAIL: MIPS RM7000 workarounds test 2 (sb1)
mips64-openbsd  -FAIL: MIPS RM7000 workarounds test 2 (vr5400)
mips64-openbsd  -FAIL: MIPS RM7000 workarounds test 2 (xlr)
mips64-openbsd  -FAIL: MIPS-OCTEON octeon_saa_saad (octeon2)
mips64-openbsd  -FAIL: MIPS-OCTEON octeon_saa_saad (octeon3)
mips64-openbsd  -FAIL: MIPS-OCTEON octeon_saa_saad (octeonp)
mips64-openbsd  -FAIL: Full MIPS R5900
mips64-openbsd  -FAIL: MIPS R5900 VU0
mips64-openbsd  -FAIL: Paired LL/SC for mips64r6 (mips64r6)
mips64el-openbsd  -FAIL: MIPS RM7000 workarounds test 2 (micromips)
mips64el-openbsd  -FAIL: MIPS RM7000 workarounds test 2 (mips3)
mips64el-openbsd  -FAIL: MIPS RM7000 workarounds test 2 (mips4)
mips64el-openbsd  -FAIL: MIPS RM7000 workarounds test 2 (mips5)
mips64el-openbsd  -FAIL: MIPS RM7000 workarounds test 2 (mips64)
mips64el-openbsd  -FAIL: MIPS RM7000 workarounds test 2 (mips64r2)
mips64el-openbsd  -FAIL: MIPS RM7000 workarounds test 2 (mips64r3)
mips64el-openbsd  -FAIL: MIPS RM7000 workarounds test 2 (mips64r5)
mips64el-openbsd  -FAIL: MIPS RM7000 workarounds test 2 (octeon)
mips64el-openbsd  -FAIL: MIPS RM7000 workarounds test 2 (octeon2)
mips64el-openbsd  -FAIL: MIPS RM7000 workarounds test 2 (octeon3)
mips64el-openbsd  -FAIL: MIPS RM7000 workarounds test 2 (octeonp)
mips64el-openbsd  -FAIL: MIPS RM7000 workarounds test 2 (r4000)
mips64el-openbsd  -FAIL: MIPS RM7000 workarounds test 2 (sb1)
mips64el-openbsd  -FAIL: MIPS RM7000 workarounds test 2 (vr5400)
mips64el-openbsd  -FAIL: MIPS RM7000 workarounds test 2 (xlr)
mips64el-openbsd  -FAIL: MIPS-OCTEON octeon_saa_saad (octeon2)
mips64el-openbsd  -FAIL: MIPS-OCTEON octeon_saa_saad (octeon3)
mips64el-openbsd  -FAIL: MIPS-OCTEON octeon_saa_saad (octeonp)
mips64el-openbsd  -FAIL: Full MIPS R5900
mips64el-openbsd  -FAIL: MIPS R5900 VU0
mips64el-openbsd  -FAIL: Paired LL/SC for mips64r6 (mips64r6)

Co-Authored-By: Maciej W. Rozycki <macro@orcam.me.uk>

	gas/
	* testsuite/gas/mips/fix-rm7000-2.d: Add `-32' to the `as' tag.
	* testsuite/gas/mips/micromips@fix-rm7000-2.d: Likewise.
	* testsuite/gas/mips/r5900-full.d: Likewise.
	* testsuite/gas/mips/r5900-vu0.d: Likewise.
	* testsuite/gas/mips/llpscp-64.d: Add `as' tag with `-32'.
	* testsuite/gas/mips/octeon-saa-saad.d: Likewise.
---
 gas/testsuite/gas/mips/fix-rm7000-2.d           |    2 +-
 gas/testsuite/gas/mips/llpscp-64.d              |    1 +
 gas/testsuite/gas/mips/micromips@fix-rm7000-2.d |    2 +-
 gas/testsuite/gas/mips/octeon-saa-saad.d        |    1 +
 gas/testsuite/gas/mips/r5900-full.d             |    2 +-
 gas/testsuite/gas/mips/r5900-vu0.d              |    2 +-
 6 files changed, 6 insertions(+), 4 deletions(-)

binutils-yunqiang-mips-test-gas-o32.diff
Index: binutils-gdb/gas/testsuite/gas/mips/fix-rm7000-2.d
===================================================================
--- binutils-gdb.orig/gas/testsuite/gas/mips/fix-rm7000-2.d
+++ binutils-gdb/gas/testsuite/gas/mips/fix-rm7000-2.d
@@ -1,4 +1,4 @@
-#as: -mfix-rm7000
+#as: -32 -mfix-rm7000
 #objdump: -dz --prefix-addresses
 #name: MIPS RM7000 workarounds test 2
 #source: fix-rm7000-2.s
Index: binutils-gdb/gas/testsuite/gas/mips/llpscp-64.d
===================================================================
--- binutils-gdb.orig/gas/testsuite/gas/mips/llpscp-64.d
+++ binutils-gdb/gas/testsuite/gas/mips/llpscp-64.d
@@ -1,4 +1,5 @@
 #objdump: -dr
+#as: -32
 #name: Paired LL/SC for mips64r6
 
 .*: +file format .*
Index: binutils-gdb/gas/testsuite/gas/mips/micromips@fix-rm7000-2.d
===================================================================
--- binutils-gdb.orig/gas/testsuite/gas/mips/micromips@fix-rm7000-2.d
+++ binutils-gdb/gas/testsuite/gas/mips/micromips@fix-rm7000-2.d
@@ -1,4 +1,4 @@
-#as: -mfix-rm7000
+#as: -32 -mfix-rm7000
 #objdump: -dz --prefix-addresses
 #name: MIPS RM7000 workarounds test 2
 #source: fix-rm7000-2.s
Index: binutils-gdb/gas/testsuite/gas/mips/octeon-saa-saad.d
===================================================================
--- binutils-gdb.orig/gas/testsuite/gas/mips/octeon-saa-saad.d
+++ binutils-gdb/gas/testsuite/gas/mips/octeon-saa-saad.d
@@ -1,4 +1,5 @@
 #objdump: -d -r --show-raw-insn
+#as: -32
 #name: MIPS-OCTEON octeon_saa_saad
 
 .*: +file format .*mips.*
Index: binutils-gdb/gas/testsuite/gas/mips/r5900-full.d
===================================================================
--- binutils-gdb.orig/gas/testsuite/gas/mips/r5900-full.d
+++ binutils-gdb/gas/testsuite/gas/mips/r5900-full.d
@@ -1,6 +1,6 @@
 #objdump: -dr --prefix-addresses --show-raw-insn -M gpr-names=numeric -mmips:5900
 #name: Full MIPS R5900
-#as: -march=r5900 -mtune=r5900
+#as: -32 -march=r5900 -mtune=r5900
 
 .*: +file format .*mips.*
 
Index: binutils-gdb/gas/testsuite/gas/mips/r5900-vu0.d
===================================================================
--- binutils-gdb.orig/gas/testsuite/gas/mips/r5900-vu0.d
+++ binutils-gdb/gas/testsuite/gas/mips/r5900-vu0.d
@@ -1,6 +1,6 @@
 #objdump: -dr --prefix-addresses --show-raw-insn -M gpr-names=numeric -mmips:5900
 #name: MIPS R5900 VU0
-#as: -march=r5900
+#as: -32 -march=r5900
 
 .*: +file format .*mips.*
 


More information about the Binutils mailing list