[PATCH 0/7] kvx: New port.

Nick Clifton nickc@redhat.com
Mon Jul 24 09:53:04 GMT 2023


Hi Paul,

   First a request: please could you add updates to the gas/NEWS and ld/NEWS
   files mentioning the fact that the KVX architecture is now supported.

   Next some code review.  I am going to skip over code formatting and comment
   structure issues for now, and also my favourite bugbear (calls to abort() in
   library code which stops the user of the library from handling error conditions),
   and instead focus on potential bugs and coding problems.  Except that I cannot
   find any!  Visual inspection may not be a perfect tool, but I have looked over
   your code and it all looks good to me.

   I will still need to check that the next set of patches compile and that the
   assembler and linker work, but I have to say that the contribution is looking
   very good so far.

Cheers
   Nick

PS.  It might me nice to have a few more KVX specific test files added to the
   assembler testsuite.  One at least that checks that each of the instructions
   assembles as expected...




More information about the Binutils mailing list