[PATCH v2] MIPS: Don't move __gnu_lto_slim to .scommon
Alan Modra
amodra@gmail.com
Thu Jul 20 09:05:30 GMT 2023
I think the patch is OK, but the same should be applied to another
place to stop objcopy modifying __gnu_lto_slim.
mips-linux-gnu testcase after running make check:
binutils/objcopy ld/tmpdir/pr15323a-r.o ld/tmpdir/xxx
then inspect ld/tmpdir/xxx with readelf.
I'm going to apply the following to mainline, and will also apply to
the 2.41 branch tomorrow if no one objects.
* elfxx-mips.c (_bfd_mips_elf_symbol_processing): Don't treat
__gnu_lto_slim as SHN_MIPS_SCOMMON.
(_bfd_mips_elf_add_symbol_hook): Likewise.
diff --git a/bfd/elfxx-mips.c b/bfd/elfxx-mips.c
index 71f2dc9d779..1e9851c3190 100644
--- a/bfd/elfxx-mips.c
+++ b/bfd/elfxx-mips.c
@@ -7176,10 +7176,11 @@ _bfd_mips_elf_symbol_processing (bfd *abfd, asymbol *asym)
case SHN_COMMON:
/* Common symbols less than the GP size are automatically
- treated as SHN_MIPS_SCOMMON symbols on IRIX5. */
+ treated as SHN_MIPS_SCOMMON symbols, with some exceptions. */
if (asym->value > elf_gp_size (abfd)
|| ELF_ST_TYPE (elfsym->internal_elf_sym.st_info) == STT_TLS
- || IRIX_COMPAT (abfd) == ict_irix6)
+ || IRIX_COMPAT (abfd) == ict_irix6
+ || strcmp (asym->name, "__gnu_lto_slim") == 0)
break;
/* Fall through. */
case SHN_MIPS_SCOMMON:
@@ -7862,10 +7863,11 @@ _bfd_mips_elf_add_symbol_hook (bfd *abfd, struct bfd_link_info *info,
{
case SHN_COMMON:
/* Common symbols less than the GP size are automatically
- treated as SHN_MIPS_SCOMMON symbols. */
+ treated as SHN_MIPS_SCOMMON symbols, with some exceptions. */
if (sym->st_size > elf_gp_size (abfd)
|| ELF_ST_TYPE (sym->st_info) == STT_TLS
- || IRIX_COMPAT (abfd) == ict_irix6)
+ || IRIX_COMPAT (abfd) == ict_irix6
+ || strcmp (*namep, "__gnu_lto_slim") == 0)
break;
/* Fall through. */
case SHN_MIPS_SCOMMON:
--
Alan Modra
Australia Development Lab, IBM
More information about the Binutils
mailing list