[PATCH] Remove duplicate pe-dll.o entry deom targ_extra_ofiles

Jan Beulich jbeulich@suse.com
Thu Jan 19 09:38:43 GMT 2023


On 19.01.2023 04:51, Khem Raj via Binutils wrote:
> Commit c60b3806799abf1d7f6cf5108a1b0e733a950b13 added support for
> aarch64-pe which introduced wrapper over pep-dll.c for x86_64 as well as
> aarch64, on x86_64 it was added but the old object pe-dll.o needs to be
> removed too, otherwise build fails with duplicate symbols from pe-dll.o
> and pep-dll-x86_64.o

Prior to said change pe-dll.o and pep-dll.o were also _both_ linked in.
You want to explain why _that_ isn't necessary anymore (if that's really
the case, which I doubt; instead I think your change breaks i386pe as
specified via targ_extra_emuls). Otherwise the duplicate symbol errors
(which, btw, I'm not seeing, so there must be more to it than you say)
need dealing with another way.

Jan


More information about the Binutils mailing list