[PATCH v2] ld: Sort section contributions in PDB files

[Mark Harmstone]

On 27/02/2023 09:13, Jan Beulich wrote:
> On 27.02.2023 01:59, Mark Harmstone wrote:
>> +  qsort (sc_in, num_sc, sizeof (struct in_sc), section_contribs_compare);
> You want to apply Nick's requested change here as well, changing
> sizeof (struct in_sc) to sizeof (* sc_in). Okay with that adjustment,
> assuming ...

Thanks Jan. I'll push it with that change, then.

>> +  ptr = *data;
>> +  sc = (struct section_contribution *) (ptr + 1); /* Skip the version word.  */
> ... you did at least consider Nick's remark regarding this, but
> didn't find any good replacement (and Nick's suggestion also didn't
> fit).

Well, that was one of Nick's suggestions, and as Alan says it's a matter of taste.

Mark