[PUSHED] Enable styling for GDB (Was: [PATCH] opcodes: style m68k disassembler output)

Andrew Burgess aburgess@redhat.com
Sat Feb 25 10:23:53 GMT 2023


Andreas,

Thanks for adding styling for m68k.

I pushed the patch below as obvious; this enables use of your new
styling within GDB.  Hope this is OK.

Thanks,
Andrew

---

commit 82341e9798202fa94b801b1428a8bf68dc80149a
Author: Andrew Burgess <aburgess@redhat.com>
Date:   Sat Feb 25 10:16:34 2023 +0000

    opcodes/m68k: enable libopcodes styling for GDB
    
    The following commit added libopcodes styling for m68k:
    
      commit c22ff449275c91e4842bb10c650e83c572580f65
      Date:   Tue Feb 14 18:07:19 2023 +0100
    
          opcodes: style m68k disassembler output
    
    but didn't set disassemble_info::created_styled_output in
    disassemble.c, which is needed in order for GDB to start using the
    libopcodes based styling.
    
    This commit fixes this small oversight.  GDB now styles correctly.

diff --git a/opcodes/disassemble.c b/opcodes/disassemble.c
index ff8cb87f599..93052e75088 100644
--- a/opcodes/disassemble.c
+++ b/opcodes/disassemble.c
@@ -652,6 +652,11 @@ disassemble_init_for_target (struct disassemble_info * info)
       info->skip_zeroes = 32;
       break;
 #endif
+#ifdef ARCH_m68k
+    case bfd_arch_m68k:
+      info->created_styled_output = true;
+      break;
+#endif
 #ifdef ARCH_mep
     case bfd_arch_mep:
       info->skip_zeroes = 256;



More information about the Binutils mailing list